[PATCH] lib: sbi: Fix printf handling of long long

[Andrew Jones]

On Wed, Jul 27, 2022 at 10:07:39PM +0800, dramforever wrote:
> Do not attempt to unnecessarily align va_list before reading long long
> arguments.

Can you please elaborate on why it was presumed necessary once, but is now
deemed not necessary?

> 
> Signed-off-by: dramforever <dramforever at live.com>
> ---
>  lib/sbi/sbi_console.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/lib/sbi/sbi_console.c b/lib/sbi/sbi_console.c
> index 34c843d..7af50e5 100644
> --- a/lib/sbi/sbi_console.c
> +++ b/lib/sbi/sbi_console.c
> @@ -261,11 +261,6 @@ static int print(char **out, u32 *out_len, const char *format, va_list args)
>  				continue;
>  			}
>  			if (*format == 'l' && *(format + 1) == 'l') {
> -				while (acnt &
> -				       (sizeof(unsigned long long) - 1)) {
> -					va_arg(args, int);
> -					acnt += sizeof(int);
> -				}

I think this should generate a "set but not used" warning with clang, as
this was the only place acnt was getting used. We can just remove all of
it.

Thanks,
drew

>  				if (sizeof(unsigned long long) ==
>  				    sizeof(unsigned long)) {
>  					tmp = va_arg(args, unsigned long long);
> -- 
> 2.37.0
> 
> 
> -- 
> opensbi mailing list
> opensbi at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/opensbi