Shakti-platform-UART-Update
Xiang W
wxjstz at 126.com
Fri Jul 1 22:59:59 PDT 2022
在 2022-07-01星期五的 20:12 +0530,Prasanna T写道:
> Please find the attached revised patch, with respect to the latest changes made. Have dealt other amendments through dts. A primary change
> that was made as part of this patch is follows.The age old version of UART was upgraded long back, but that was missed out in the code which
> we did updated now (The old version of UART is not supported anymore, hence removed the inline comment which is also outdated now), The
> current version is the only UART supported right now by Shakti
> ---
>
> diff --git a/lib/utils/serial/shakti-uart.c b/lib/utils/serial/shakti-uart.c
> index 5f2fe75..122218b 100644
> --- a/lib/utils/serial/shakti-uart.c
> +++ b/lib/utils/serial/shakti-uart.c
> @@ -19,21 +19,22 @@
> #define REG_RX_THRES 0x20
>
> #define UART_TX_FULL 0x2
> +#define UART_RX_NOT_EMPTY 0x4
> #define UART_RX_FULL 0x8
>
> static volatile char *uart_base;
>
> static void shakti_uart_putc(char ch)
> {
> - while((readw(uart_base + REG_STATUS) & UART_TX_FULL))
> + while((readb(uart_base + REG_STATUS) & UART_TX_FULL))
> ;
> writeb(ch, uart_base + REG_TX);
> }
>
> static int shakti_uart_getc(void)
> {
> - u16 status = readw(uart_base + REG_STATUS);
> - if (status & UART_RX_FULL)
> + u16 status = readb(uart_base + REG_STATUS);
readb return u8. So the type of 'status' needs to be u8.
Regards,
Xiang W
> + if (status & UART_RX_NOT_EMPTY)
> return readb(uart_base + REG_RX);
> return -1;
> }
>
More information about the opensbi
mailing list