[PATCH v2 1/2] lib: utils/ipi: Fix size check in aclint_mswi_cold_init()

[Alistair Francis]

On Sun, 2022-01-09 at 20:50 +0530, Anup Patel wrote:
> Currently, the ACLINT MSWI size check is forcing size to be at least
> 0x4000. This is inappropriate check because most systems will never
> utilize full 16KB for a single ACLINT MSWI device so instead we
> should
> check that ACLINT MSWI size is enough for on the associated HARTs.
> 
> Signed-off-by: Anup Patel <apatel at ventanamicro.com>
> Reviewed-by: Dong Du <Dd_nirvana at sjtu.edu.cn>

Reviewed-by: Alistair Francis <alistair.francis at wdc.com>

Alistair

> ---
>  lib/utils/ipi/aclint_mswi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/utils/ipi/aclint_mswi.c
> b/lib/utils/ipi/aclint_mswi.c
> index a3de2f5..832e223 100644
> --- a/lib/utils/ipi/aclint_mswi.c
> +++ b/lib/utils/ipi/aclint_mswi.c
> @@ -74,7 +74,7 @@ int aclint_mswi_cold_init(struct aclint_mswi_data
> *mswi)
>  
>         /* Sanity checks */
>         if (!mswi || (mswi->addr & (ACLINT_MSWI_ALIGN - 1)) ||
> -           (mswi->size < ACLINT_MSWI_SIZE) ||
> +           (mswi->size < (mswi->hart_count * sizeof(u32))) ||
>             (mswi->first_hartid >= SBI_HARTMASK_MAX_BITS) ||
>             (mswi->hart_count > ACLINT_MSWI_MAX_HARTS))
>                 return SBI_EINVAL;