[PATCH 1/2] platform: sifive_fu740: do not use a global in da9063_reset/shutdown

Xiang W wxjstz at 126.com
Wed Jan 5 17:26:43 PST 2022


在 2022-01-05星期三的 08:20 +0100,Aurelien Jarno写道:
> da9063_reset() and da9063_shutdown() take the chip address in argument
> (like similar functions), but in practice use the da9063 global struct
> instead. Fix that.
> 
> Signed-off-by: Aurelien Jarno <aurelien at aurel32.net>
look good to me.

Reviewed-by: Xiang W <wxjstz at 126.com>
> ---
>  platform/generic/sifive_fu740.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/platform/generic/sifive_fu740.c
> b/platform/generic/sifive_fu740.c
> index 333b3fb..866e924 100644
> --- a/platform/generic/sifive_fu740.c
> +++ b/platform/generic/sifive_fu740.c
> @@ -81,32 +81,32 @@ static inline int da9063_sanity_check(struct
> i2c_adapter *adap, uint32_t reg)
>  
>  static inline int da9063_shutdown(struct i2c_adapter *adap, uint32_t
> reg)
>  {
> -       int rc = i2c_adapter_reg_write(adap, da9063.reg,
> +       int rc = i2c_adapter_reg_write(adap, reg,
>                                         DA9063_REG_PAGE_CON, 0x00);
>  
>         if (rc)
>                 return rc;
>  
> -       return i2c_adapter_reg_write(adap, da9063.reg,
> +       return i2c_adapter_reg_write(adap, reg,
>                                      DA9063_REG_CONTROL_F,
>                                      DA9063_CONTROL_F_SHUTDOWN);
>  }
>  
>  static inline int da9063_reset(struct i2c_adapter *adap, uint32_t
> reg)
>  {
> -       int rc = i2c_adapter_reg_write(adap, da9063.reg,
> +       int rc = i2c_adapter_reg_write(adap, reg,
>                                         DA9063_REG_PAGE_CON, 0x00);
>  
>         if (rc)
>                 return rc;
>  
> -       rc = i2c_adapter_reg_write(adap, da9063.reg,
> +       rc = i2c_adapter_reg_write(adap, reg,
>                                    DA9063_REG_CONTROL_F,
>                                    DA9063_CONTROL_F_WAKEUP);
>         if (rc)
>                 return rc;
>  
> -       return i2c_adapter_reg_write(adap, da9063.reg,
> +       return i2c_adapter_reg_write(adap, reg,
>                                 DA9063_REG_CONTROL_A,
>                                 DA9063_CONTROL_A_M_POWER1_EN |
>                                 DA9063_CONTROL_A_M_POWER_EN |
> -- 
> 2.34.1
> 
> 





More information about the opensbi mailing list