[PATCH 1/3] lib: sbi: fix typo in is_region_subset

Dong Du dd_nirvana at sjtu.edu.cn
Sat Feb 12 00:34:42 PST 2022



On Feb 11, 2022, at 7:11 PM, Nikita Shubin nikita.shubin at maquefel.me wrote:

> From: Nikita Shubin <n.shubin at yadro.com>
> 
> Fix typo in is_region_subset, regB_end should be calculated from regB.
> 
> Signed-off-by: Nikita Shubin <n.shubin at yadro.com>

Looks good to me. Thx for the patch.

Reviewed-by: Dong Du <Dd_nirvana at sjtu.edu.cn>

Regards,
Dong

> ---
> lib/sbi/sbi_domain.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/sbi/sbi_domain.c b/lib/sbi/sbi_domain.c
> index b60915c..a1ac1bb 100644
> --- a/lib/sbi/sbi_domain.c
> +++ b/lib/sbi/sbi_domain.c
> @@ -159,7 +159,7 @@ static bool is_region_subset(const struct
> sbi_domain_memregion *regA,
> 	ulong regA_start = regA->base;
> 	ulong regA_end = regA->base + (BIT(regA->order) - 1);
> 	ulong regB_start = regB->base;
> -	ulong regB_end = regB->base + (BIT(regA->order) - 1);
> +	ulong regB_end = regB->base + (BIT(regB->order) - 1);
> 
> 	if ((regB_start <= regA_start) &&
> 	    (regA_start < regB_end) &&
> --
> 2.31.1
> 
> 
> --
> opensbi mailing list
> opensbi at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/opensbi



More information about the opensbi mailing list