[PATCH Zisslpcfi 2/2] lib: sbi: zsslpcfi detection and elp cfi state reflect back in status

Bin Meng bmeng.cn at gmail.com
Wed Dec 21 17:29:55 PST 2022


On Thu, Dec 22, 2022 at 2:41 AM Deepak Gupta <debug at rivosinc.com> wrote:
>
> On Wed, Dec 21, 2022 at 5:43 AM Bin Meng <bmeng.cn at gmail.com> wrote:
> >
> > > @@ -87,6 +87,7 @@ int sbi_trap_redirect(struct sbi_trap_regs *regs,
> > >                       struct sbi_trap_info *trap)
> > >  {
> > >         ulong hstatus, vsstatus, prev_mode;
> > > +       bool elp = FALSE;
> >
> > s/FALSE/false
>
> I followed whatever rest of the code is following. In the same function
>
> "
> int sbi_trap_redirect(struct sbi_trap_regs *regs,
>                       struct sbi_trap_info *trap)
> {
>         ulong hstatus, vsstatus, prev_mode;
>         bool elp = FALSE;
> #if __riscv_xlen == 32
>         bool prev_virt = (regs->mstatusH & MSTATUSH_MPV) ? TRUE : FALSE;
> #else
>         bool prev_virt = (regs->mstatus & MSTATUS_MPV) ? TRUE : FALSE;
> #endif
>         /* By default, we redirect to HS-mode */
>         bool next_virt = FALSE;
> "
> I can change it to false but it'll look ugly because at other places
> we're using upper case FALSE.
> Let me know what needs to be done.
>

No need to worry about other places, as I already sent one patch to
change all other places.

Regards,
Bin



More information about the opensbi mailing list