[PATCH v3 3/3] generic/starfive: Add Starfive JH7110 platform implementation

[WeiLiang Lim]

> -----Original Message-----
> From: Jessica Clarke <jrtc27 at jrtc27.com>
> Sent: Monday, December 12, 2022 2:05 PM
> To: WeiLiang Lim <weiliang.lim at starfivetech.com>
> Cc: opensbi <opensbi at lists.infradead.org>; Anup Patel
> <apatel at ventanamicro.com>; Cheehong Ang
> <cheehong.ang at starfivetech.com>; JunLiang Tan
> <junliang.tan at starfivetech.com>
> Subject: Re: [PATCH v3 3/3] generic/starfive: Add Starfive JH7110 platform
> implementation
> 
> On 12 Dec 2022, at 06:04, WeiLiang Lim <weiliang.lim at starfivetech.com>
> wrote:
> >
> >
> >
> >> -----Original Message-----
> >> From: Jessica Clarke <jrtc27 at jrtc27.com>
> >> Sent: Monday, December 12, 2022 1:40 PM
> >> To: WeiLiang Lim <weiliang.lim at starfivetech.com>
> >> Cc: opensbi <opensbi at lists.infradead.org>; Anup Patel
> >> <apatel at ventanamicro.com>; Cheehong Ang
> >> <cheehong.ang at starfivetech.com>; JunLiang Tan
> >> <junliang.tan at starfivetech.com>
> >> Subject: Re: [PATCH v3 3/3] generic/starfive: Add Starfive JH7110
> >> platform implementation
> >>
> >> On 12 Dec 2022, at 05:19, Wei Liang Lim
> >> <weiliang.lim at starfivetech.com>
> >> wrote:
> >>>
> >>> Add Starfive JH7110 platform implementation
> >>>
> >>> Signed-off-by: Wei Liang Lim <weiliang.lim at starfivetech.com>
> >>> Reviewed-by: Chee Hong Ang <cheehong.ang at starfivetech.com>
> >>> Reviewed-by: Jun Liang Tan <junliang.tan at starfivetech.com>
> >>> ---
> >>> platform/generic/Kconfig             |  4 ++++
> >>> platform/generic/configs/defconfig   |  1 +
> >>> platform/generic/starfive/jh7110.c   | 27 +++++++++++++++++++++++++++
> >>> platform/generic/starfive/objects.mk |  6 ++++++
> >>> 4 files changed, 38 insertions(+)
> >>> create mode 100644 platform/generic/starfive/jh7110.c
> >>> create mode 100644 platform/generic/starfive/objects.mk
> >>>
> >>> diff --git a/platform/generic/Kconfig b/platform/generic/Kconfig
> >>> index 4b5d2cd..a6e467d 100644
> >>> --- a/platform/generic/Kconfig
> >>> +++ b/platform/generic/Kconfig
> >>> @@ -41,4 +41,8 @@ config PLATFORM_SIFIVE_FU740
> >>> 	depends on FDT_RESET && FDT_I2C
> >>> 	default n
> >>>
> >>> +config PLATFORM_STARFIVE_JH7110
> >>> +	bool "StarFive JH7110 support"
> >>> +	default n
> >>> +
> >>> endif
> >>> diff --git a/platform/generic/configs/defconfig
> >>> b/platform/generic/configs/defconfig
> >>> index 2eaeeb7..ef6aad9 100644
> >>> --- a/platform/generic/configs/defconfig
> >>> +++ b/platform/generic/configs/defconfig
> >>> @@ -2,6 +2,7 @@ CONFIG_PLATFORM_ALLWINNER_D1=y
> >>> CONFIG_PLATFORM_ANDES_AE350=y
> CONFIG_PLATFORM_SIFIVE_FU540=y
> >>> CONFIG_PLATFORM_SIFIVE_FU740=y
> >>> +CONFIG_PLATFORM_STARFIVE_JH7110=y
> >>> CONFIG_FDT_GPIO=y
> >>> CONFIG_FDT_GPIO_SIFIVE=y
> >>> CONFIG_FDT_I2C=y
> >>> diff --git a/platform/generic/starfive/jh7110.c
> >>> b/platform/generic/starfive/jh7110.c
> >>> new file mode 100644
> >>> index 0000000..1c76975
> >>> --- /dev/null
> >>> +++ b/platform/generic/starfive/jh7110.c
> >>> @@ -0,0 +1,27 @@
> >>> +/*
> >>> + * SPDX-License-Identifier: BSD-2-Clause
> >>> + *
> >>> + * Copyright (c) 2022 StarFive
> >>> + *
> >>> + * Authors:
> >>> + *   Wei Liang Lim <weiliang.lim at starfivetech.com>
> >>> + */
> >>> +
> >>> +#include <platform_override.h>
> >>> +#include <sbi_utils/fdt/fdt_helper.h>
> >>> +
> >>> +static bool starfive_cold_boot_allowed(u32 hartid,
> >>> +				   const struct fdt_match *match) {
> >>> +	return (hartid == 1);
> >>
> >> Why? I thought in an earlier thread it was said this was just a
> >> debugging thing and you should fix whatever bug this masks another way.
> >>
> >> This at least needs a justification in the source code.
> >>
> >> Jess
> >
> > Hi Jess,
> >
> > Sorry I did something wrong previously causing some patch being missed out.
> > Please refer to my latest submission.
> > In earlier conversation, Anup helped to review and suggested patches to
> allow platform to influence cold boot HART selection and allow
> platform_override to select cold boot HART. Together with Anup's patches I
> have included StarFive platform specific implementation.
> 
> But why does the JH110 need this?
> 
> Jess
> 

Hi Jess,

This is mainly to support our customer request which they need a preferred boot hart in their product application.
For better flexibility, we are planning for a v4 version where user can have the option to specify the preferred boot hart in dts chosen node. If unspecified, it will just use the current default lottery mechanism.

Thanks


> >>
> >>> +}
> >>> +
> >>> +static const struct fdt_match starfive_jh7110_match[] = {
> >>> +	{ .compatible = "starfive,jh7110" },
> >>> +	{ },
> >>> +};
> >>> +
> >>> +const struct platform_override starfive_jh7110 = {
> >>> +	.match_table = starfive_jh7110_match,
> >>> +	.cold_boot_allowed = starfive_cold_boot_allowed, };
> >>> diff --git a/platform/generic/starfive/objects.mk
> >>> b/platform/generic/starfive/objects.mk
> >>> new file mode 100644
> >>> index 0000000..0b900fb
> >>> --- /dev/null
> >>> +++ b/platform/generic/starfive/objects.mk
> >>> @@ -0,0 +1,6 @@
> >>> +#
> >>> +# SPDX-License-Identifier: BSD-2-Clause #
> >>> +
> >>> +carray-platform_override_modules-
> >> $(CONFIG_PLATFORM_STARFIVE_JH7110)
> >>> ++= starfive_jh7110
> >>> +platform-objs-$(CONFIG_PLATFORM_STARFIVE_JH7110) +=
> >> starfive/jh7110.o
> >>> --
> >>> 2.25.1
> >>>
> >>>
> >>> --
> >>> opensbi mailing list
> >>> opensbi at lists.infradead.org
> >>> http://lists.infradead.org/mailman/listinfo/opensbi