[PATCH v3 1/5] lib: utils/irqchip: plic: Fix the off-by-one error in priority save/restore helpers
Bin Meng
bmeng at tinylab.org
Sat Dec 10 22:54:20 PST 2022
Interrupt source 0 is reserved. Hence the irq should start from 1.
Fixes: 2b79b694a805 ("lib: irqchip/plic: Add priority save/restore helpers")
Signed-off-by: Bin Meng <bmeng at tinylab.org>
Reviewed-by: Anup Patel <anup at brainfault.org>
---
(no changes since v1)
lib/utils/irqchip/plic.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/utils/irqchip/plic.c b/lib/utils/irqchip/plic.c
index 73d7788..4df9020 100644
--- a/lib/utils/irqchip/plic.c
+++ b/lib/utils/irqchip/plic.c
@@ -38,13 +38,13 @@ static void plic_set_priority(const struct plic_data *plic, u32 source, u32 val)
void plic_priority_save(const struct plic_data *plic, u8 *priority)
{
- for (u32 i = 0; i < plic->num_src; i++)
+ for (u32 i = 1; i <= plic->num_src; i++)
priority[i] = plic_get_priority(plic, i);
}
void plic_priority_restore(const struct plic_data *plic, const u8 *priority)
{
- for (u32 i = 0; i < plic->num_src; i++)
+ for (u32 i = 1; i <= plic->num_src; i++)
plic_set_priority(plic, i, priority[i]);
}
--
2.34.1
More information about the opensbi
mailing list