[PATCH] Makefile: replace `echo` with `printf` for compatibility

[Anup Patel]

On Mon, Nov 21, 2022 at 9:29 PM KaDiWa <kalle.wachsmuth at gmail.com> wrote:
>
> I don't know why but `echo -n` didn't work for me. macOS supports the `-n` option but it doesn't work in the makefile. What it does instead is it literally writes `-n` to the file and then also
> leaves a newline at the end.

Please try to wrap your commit description text within 80 characters.

>
> I'm using GNU Make 4.4 (`gmake` from Homebrew).
>
> Signed-off-by: KaDiWa <kalle.wachsmuth at gmail.com>
> ---
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 8db6eab..98e42fc 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -224,7 +224,7 @@ $(KCONFIG_CONFIG): $(platform_src_dir)/configs/$(PLATFORM_DEFCONFIG) $(platform_
>
>  $(KCONFIG_AUTOCMD): $(KCONFIG_CONFIG)
>         $(CMD_PREFIX)mkdir -p $(KCONFIG_DIR)
> -       $(CMD_PREFIX)echo -n "$(KCONFIG_CONFIG): " > $(KCONFIG_AUTOCMD)
> +       $(CMD_PREFIX)printf "%s: " $(KCONFIG_CONFIG) > $(KCONFIG_AUTOCMD)
>         $(CMD_PREFIX)cat $(KCONFIG_AUTOLIST) | tr '\n' ' ' >> $(KCONFIG_AUTOCMD)
>
>  include $(KCONFIG_CONFIG)
> --
> 2.37.1 (Apple Git-137.1)
>
>
> --
> opensbi mailing list
> opensbi at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/opensbi

Apart from the above comment, this looks good to me. I have
taken care of the above comment at the time of merging this patch.

Reviewed-by: Anup Patel <anup at brainfault.org>

Applied this patch to the riscv/opensbi repo.

Thanks,
Anup