[PATCH v3 1/6] lib: utils: serial: Add Renesas SCIF driver

Lad, Prabhakar prabhakar.csengg at gmail.com
Thu Dec 1 02:47:47 PST 2022


On Thu, Dec 1, 2022 at 10:40 AM Biju Das <biju.das.jz at bp.renesas.com> wrote:
>
>
<snip>
> > +
> > +     set_reg(SCIF_REG_FTDR, ch);
> > +     reg = get_reg(SCIF_REG_FSR);
> > +     reg &= ~SCIF_FSR_TXD_CHK;
> > +     set_reg(SCIF_REG_FSR, reg);
> > +}
> > +
> > +static struct sbi_console_device renesas_scif_console = {
> > +     .name           = "renesas_scif",
> > +     .console_putc   = renesas_scif_putc,
> > +};
> > +
> > +int renesas_scif_init(unsigned long base, u32 in_freq, u32 baudrate) {
> > +     volatile uint16_t data16;
>
> Why volatile??
>
Yep not needed. I will drop it.

Cheers,
Prabhakar



More information about the opensbi mailing list