[PATCH v3 1/6] lib: utils: serial: Add Renesas SCIF driver

[Lad, Prabhakar]

Hi Biju,

Thank you for the review.

On Thu, Dec 1, 2022 at 8:27 AM Biju Das <biju.das.jz at bp.renesas.com> wrote:
>
> Hi Prabhakar,
>
> > -----Original Message-----
> > From: Prabhakar <prabhakar.csengg at gmail.com>
> > Sent: 30 November 2022 22:08
> > To: Anup Patel <anup at brainfault.org>; Atish Patra
> > <atishp at atishpatra.org>; opensbi at lists.infradead.org
> > Cc: Yu Chien Peter Lin <peterlin at andestech.com>; Bin Meng
> > <bmeng.cn at gmail.com>; Andrew Jones <ajones at ventanamicro.com>; Prabhakar
> > <prabhakar.csengg at gmail.com>; Biju Das <biju.das.jz at bp.renesas.com>;
> > Chris Paterson <Chris.Paterson2 at renesas.com>; Prabhakar Mahadev Lad
> > <prabhakar.mahadev-lad.rj at bp.renesas.com>
> > Subject: [PATCH v3 1/6] lib: utils: serial: Add Renesas SCIF driver
> >
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj at bp.renesas.com>
> >
> > Add Renesas SCIF driver.
<snip>
> > +static u32 get_reg(u32 offset)
> > +{
> > +     if (SCIF_REG_8BIT(offset))
> > +             return readb(scif_base + offset);
> > +
> > +     return readw(scif_base + offset);
> > +}
> > +
> > +static void set_reg(u32 offset, u32 val) {
> > +     if (SCIF_REG_8BIT(offset))
> > +             return writeb(val, scif_base + offset);
>
> You are returning from void function. Same below as well.
>
Good catch, the compiler didn't warn me.

Cheers,
Prabhakar