[RFC PATCH 0/2] system reset rework to list, priority

[Anup Patel]

On Wed, Sep 29, 2021 at 3:12 PM Nikita Shubin <nikita.shubin at maquefel.me> wrote:
>
> From: Nikita Shubin <n.shubin at yadro.com>
>
> Hi Anup.
>
> I decided to go as separate proposal for system reset, as i don't think
> da9063 is really connected to this one.

Overall the approach taken by this series is in right direction but need
to address some comments.

>
> Let's rework our current sbi_system reset to support multiply reset
> handlers.
>
> However there are some things to discuss. If we want priority handling like in Linux,
> we need separate lists for each reset type and sort them on insertions.

We don't need to have priority for each reset_type. I think priority per-device
is sufficient. This way will have just one list of reset devices.

>
> If we go the way like in the second patch no separate lists are needed but we will lack
> the ability to call them in chain.
>
> So what are your thoughts ?
>
> Nikita Shubin (2):
>   lib: sbi: convert reset to list
>   lib: sbi: add priority for reset handler
>
>  include/sbi/sbi_system.h              | 13 +++++--
>  lib/sbi/sbi_init.c                    |  5 ++-
>  lib/sbi/sbi_system.c                  | 50 +++++++++++++++++++--------
>  lib/utils/reset/fdt_reset_gpio.c      |  2 +-
>  lib/utils/reset/fdt_reset_sunxi_wdt.c |  2 +-
>  lib/utils/reset/fdt_reset_thead.c     |  2 +-
>  lib/utils/sys/htif.c                  |  2 +-
>  lib/utils/sys/sifive_test.c           |  2 +-
>  platform/kendryte/k210/platform.c     |  2 +-
>  platform/nuclei/ux600/platform.c      |  2 +-
>  10 files changed, 58 insertions(+), 24 deletions(-)
>
> --
> 2.31.1
>
>
> --
> opensbi mailing list
> opensbi at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/opensbi

Regards,
Anup