[PATCH 1/1] lib: utils: identify supported GPIO reset methods

[Nikita Shubin]

On Wed, 29 Sep 2021 09:46:55 +0530
Anup Patel <anup at brainfault.org> wrote:

> +Nikita
> 
> On Tue, Sep 28, 2021 at 5:13 PM Heinrich Schuchardt
> <heinrich.schuchardt at canonical.com> wrote:
> >
> > The GPIO reset driver supports reset and poweroff. But not all
> > boards support both. gpio_system_reset_check() must detect this
> > situation.
> >
> > Signed-off-by: Heinrich Schuchardt
> > <heinrich.schuchardt at canonical.com>  
> 
> Looks good to me.
> 
> Reviewed-by: Anup Patel <anup.patel at wdc.com>
> 
> I had mentioned on the PMIC reset series that we need to improve
> the sbi_system.h device registration such that reset drivers can
> register a reset device for a range of reset types. This will allow
> separate reset drivers (e.g. PMIC+GPIO) for SiFive Unmatched.
> Also, reset_check() callback will not be required anymore.
> 
> Regards,
> Anup

Looks good to me, however

> > +       /* hang !!! */
> > +       sbi_hart_hang();
> >  }

Heinrich do we really need to hang here ?

Despite the gpio_system_reset should never reach the end of function, 
i remember you talked something about returning from function back to
the sbi_system_reset.

Yours,
Nikita Shubin