[PATCH 1/4] lib: utils/i2c: Add generic I2C configuration library

Alexandre Ghiti alexandre.ghiti at canonical.com
Tue Sep 28 04:43:38 PDT 2021


On Tue, Sep 28, 2021 at 12:52 PM Nikita Shubin
<nikita.shubin at maquefel.me> wrote:
>
> Hi Alexander,
>
> Thank you for your attention.
>
> On Mon, 27 Sep 2021 17:41:18 +0200
> Alexandre ghiti <alex at ghiti.fr> wrote:
>
> > And I don't think the configure callback is even needed: it should be
> > done at the initialization of the adapter, in its own driver, I don't
> > think the device should care about that.
>
> As long as i2c frame is supposed to do something more complicated then
> sending a few bytes at the very end and even, may be, at the start of
> booting, it is definitely required to configure - setup clocks, enable
> the device.

I agree that some configurations need to be done but the i2c device
should not care about that, it should only ask to send/recv, the
adapter should do the necessary configuration behind the scenes.

>
> Yours,
> Nikita Shubin
>
> --
> opensbi mailing list
> opensbi at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/opensbi



More information about the opensbi mailing list