[PATCH v2 05/15] lib: sbi: Disable m/scounteren & enable mcountinhibit

Jessica Clarke jrtc27 at jrtc27.com
Wed May 26 17:36:14 PDT 2021


On 27 May 2021, at 01:30, Atish Patra <atish.patra at wdc.com> wrote:
> 
> Currently, all bits in mcountern are enabled unconditionally at
> boot time. With SBI PMU extension, this should enabled only during
> performance monitoring for a particular event except the TM bit. However,
> this is done only if mcountinhibit is implemented because the supervisor
> mode can not start/stop any event without mcountinhibit.
> 
> Similarly, supervisor should take care enabling scounteren which allows
> U-mode to access pmu counters. Disable all bits in scounteren in M-mode.

Turning off CY or IR seems like a bad idea to me. Similarly, all of CY, IR and
TM should be enabled in scounteren by default, this is just needlessly hostile.
IMO both mcounteren and scounteren should be initialised to 7 on boot.

Jess




More information about the opensbi mailing list