[PATCH v2 1/3] lib: utils: Add strncpy macro to libfdt_env.h

Anup Patel Anup.Patel at wdc.com
Wed May 19 13:54:24 BST 2021



> -----Original Message-----
> From: Anup Patel
> Sent: 19 May 2021 18:22
> To: Xiang W <wxjstz at 126.com>; Daniel Schaefer
> <daniel.schaefer at hpe.com>; opensbi at lists.infradead.org
> Cc: Abner Chang <abner.chang at hpe.com>
> Subject: RE: [PATCH v2 1/3] lib: utils: Add strncpy macro to libfdt_env.h
> 
> 
> 
> > -----Original Message-----
> > From: Xiang W <wxjstz at 126.com>
> > Sent: 19 May 2021 14:08
> > To: Daniel Schaefer <daniel.schaefer at hpe.com>;
> > opensbi at lists.infradead.org
> > Cc: Abner Chang <abner.chang at hpe.com>; Anup Patel
> <Anup.Patel at wdc.com>
> > Subject: Re: [PATCH v2 1/3] lib: utils: Add strncpy macro to
> > libfdt_env.h
> >
> > 在 2021-05-19三的 15:54 +0800,Daniel Schaefer写道:
> > > Just like 2845d2d2cf4fb74a89452ba223995aa4a118c07e
> > > we want to use sbi_strncpy as strncpy in the OpenSBI implementation
> > > for libfdt.
> > >
> > > Cc: Abner Chang <abner.chang at hpe.com>
> > > Cc: Anup Patel <Anup.Patel at wdc.com>
> > > Signed-off-by: Daniel Schaefer <daniel.schaefer at hpe.com>
> > > Reviewed-by: Abner Chang <abner.chang at hpe.com>
> >
> > Reviewed-by: Xiang W <wxjstz at 126.com>
> 
> Looks good to me.
> 
> Reviewed-by: Anup Patel <anup.patel at wdc.com>

Forgot to mention that I have applied this patch to the riscv/opensbi repo.

Thanks,
Anup

> 
> Regards,
> Anup
> 
> >
> > > ---
> > >  lib/utils/libfdt/libfdt_env.h | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/lib/utils/libfdt/libfdt_env.h
> > > b/lib/utils/libfdt/libfdt_env.h index bc3e7588660a..f9d9c6783c52
> > > 100644
> > > --- a/lib/utils/libfdt/libfdt_env.h
> > > +++ b/lib/utils/libfdt/libfdt_env.h
> > > @@ -31,6 +31,7 @@
> > >  #define strchr		sbi_strchr
> > >  #define strrchr		sbi_strrchr
> > >  #define strcpy		sbi_strcpy
> > > +#define strncpy		sbi_strncpy
> > >  #define strcmp		sbi_strcmp
> > >  #define strncmp		sbi_strncmp
> > >  #define strlen		sbi_strlen
> > > --
> > > 2.30.1
> > >
> > >



More information about the opensbi mailing list