[PATCH] Makefile: unconditionally disable SSP

[Anup Patel]

> -----Original Message-----
> From: opensbi <opensbi-bounces at lists.infradead.org> On Behalf Of Xiang W
> Sent: 15 May 2021 17:37
> To: Fabrice Fontaine <fontaine.fabrice at gmail.com>;
> opensbi at lists.infradead.org
> Subject: Re: [PATCH] Makefile: unconditionally disable SSP
> 
> 在 2021-05-15六的 10:16 +0200，Fabrice Fontaine写道：
> > Though -nostdlib is passed in CFLAGS, -fno-stack-protector must also
> > be passed to avoid linking errors related to undefined references to
> > '__stack_chk_guard' and '__stack_chk_fail' if toolchain enforces
> > -fstack-protector.
> >
> > Fixes:
> >  - https://gitlab.com/kubu93/buildroot/-/jobs/1247043359
> >
> 
> Reviewed-by: Xiang W <wxjstz at 126.com>

Applied this patch to the riscv/opensbi repo.

Regards,
Anup

> 
> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice at gmail.com>
> > ---
> >  Makefile | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Makefile b/Makefile
> > index eeffe6b..6b64205 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -203,7 +203,7 @@ GENFLAGS	+=	$(libsbiutils-genflags-y)
> >  GENFLAGS	+=	$(platform-genflags-y)
> >  GENFLAGS	+=	$(firmware-genflags-y)
> >
> > -CFLAGS		=	-g -Wall -Werror -ffreestanding -nostdlib
> > -fno-strict-aliasing -O2
> > +CFLAGS		=	-g -Wall -Werror -ffreestanding -nostdlib
> > -fno-stack-protector -fno-strict-aliasing -O2
> >  CFLAGS		+=	-fno-omit-frame-pointer -fno-
> > optimize-sibling-calls
> >  CFLAGS		+=	-mno-save-restore -mstrict-align
> >  CFLAGS		+=	-mabi=$(PLATFORM_RISCV_ABI)
> > -march=$(PLATFORM_RISCV_ISA)
> > --
> > 2.30.2
> >
> >
> 
> 
> --
> opensbi mailing list
> opensbi at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/opensbi