[PATCH v1 1/3] lib: utils: Add macro to libfdt_env.h for strncpy

Xiang W wxjstz at 126.com
Mon May 17 14:47:37 BST 2021


在 2021-05-17一的 19:33 +0800,Daniel Schaefer写道:
> Just like 2845d2d2cf4fb74a89452ba223995aa4a118c07e
> 
> Cc: Abner Chang <abner.chang at hpe.com>
> Cc: Anup Patel <Anup.Patel at wdc.com>
> Signed-off-by: Daniel Schaefer <daniel.schaefer at hpe.com>
Look good to me.
This description doesn't look very clear.

I recommend reword:

lib: utils: Add a macro in libfdt_env.h for strncpy

This commit add a macro to replace strncpy with sbi_strncpy.

Regards
Xiang W
> ---
>  lib/utils/libfdt/libfdt_env.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/lib/utils/libfdt/libfdt_env.h
> b/lib/utils/libfdt/libfdt_env.h
> index bc3e7588660a..f9d9c6783c52 100644
> --- a/lib/utils/libfdt/libfdt_env.h
> +++ b/lib/utils/libfdt/libfdt_env.h
> @@ -31,6 +31,7 @@
>  #define strchr		sbi_strchr
>  #define strrchr		sbi_strrchr
>  #define strcpy		sbi_strcpy
> +#define strncpy		sbi_strncpy
>  #define strcmp		sbi_strcmp
>  #define strncmp		sbi_strncmp
>  #define strlen		sbi_strlen
> -- 
> 2.30.1
> 
> 




More information about the opensbi mailing list