[PATCH 0/3] Support position independent execution

Vincent Chen vincent.chen at sifive.com
Fri Mar 5 03:48:47 GMT 2021


On Thu, Mar 4, 2021 at 3:33 PM Anup Patel <Anup.Patel at wdc.com> wrote:
>
> Hi Vincent,
>
> Overall the changes are in quite good shape.
>
> I have few high-level comments before I can review fw_base.S in detail:
> 1) No need to change toplevel Makefile for appending compiler and linker
>     options. It is better to update $(firmware-genflags-y), $(firmware-cflags-y)
>     and $(firmware-ldflags-y) in firmware/objects.mk
> 2) I would suggest to squash PATCH2 and PATCH3 into one PATCH and
>     make this PATCH as PATCH1
> 3) The current PATCH1 can be PATCH2
>
OK, I got it. I will follow your suggestions to modify this patch.
Thank you.



More information about the opensbi mailing list