[PATCH 1/1] lib: sign conflict in sbi_tlb_entry_process()

Xiang W wxjstz at 126.com
Mon Jun 21 23:41:55 PDT 2021


在 2021-06-21星期一的 21:50 +0200,Heinrich Schuchardt写道:
> Compiling sbi_tlb_entry_process() with GCC 11 and -Wextra yields:
> 
> lib/sbi/sbi_tlb.c: In function ‘sbi_tlb_process_count’:
> lib/sbi/sbi_tlb.c:206:31:
> error: comparison of integer expressions of different signedness:
> ‘u32’ {aka ‘unsigned int’} and ‘int’ [-Werror=sign-compare]
>   206 |                 if (deq_count > count)
> 
Reviewed-by: Xiang W <wxjstz at 126.com>

Regards,
Xiang W

> Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
> ---
>  lib/sbi/sbi_tlb.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/sbi/sbi_tlb.c b/lib/sbi/sbi_tlb.c
> index 2ba1b7b..8bbe92b 100644
> --- a/lib/sbi/sbi_tlb.c
> +++ b/lib/sbi/sbi_tlb.c
> @@ -193,10 +193,11 @@ static void sbi_tlb_entry_process(struct
> sbi_tlb_info *tinfo)
>         }
>  }
> 
> -static void sbi_tlb_process_count(struct sbi_scratch *scratch, int
> count)
> +static void sbi_tlb_process_count(struct sbi_scratch *scratch,
> +                                 unsigned int count)
>  {
>         struct sbi_tlb_info tinfo;
> -       u32 deq_count = 0;
> +       unsigned int deq_count = 0;
>         struct sbi_fifo *tlb_fifo =
>                         sbi_scratch_offset_ptr(scratch,
> tlb_fifo_off);
> 
> --
> 2.30.2
> 
> 





More information about the opensbi mailing list