[PATCH 3/3] include: sbi: Don't pack struct sbi_platform and sbi_platform_operations

[Anup Patel]

> -----Original Message-----
> From: Alistair Francis <Alistair.Francis at wdc.com>
> Sent: 14 January 2021 01:15
> To: Atish Patra <Atish.Patra at wdc.com>; Anup Patel
> <Anup.Patel at wdc.com>
> Cc: anup at brainfault.org; opensbi at lists.infradead.org; taniwha at gmail.com
> Subject: Re: [PATCH 3/3] include: sbi: Don't pack struct sbi_platform and
> sbi_platform_operations
> 
> On Wed, 2021-01-13 at 15:36 +0530, Anup Patel wrote:
> > We don't need to pack struct sbi_platform and sbi_platform_operations
> > because GCC ensures member offsets match member data type
> irrespective
> > to the target system (RV32 or RV64). This also allows GCC to generate
> > more optimized instruction sequence when accessing members of struct
> > sbi_platform and struct sbi_platform_operations.
> >
> > Reported-by: Paul Campbell <taniwha at gmail.com>
> > Signed-off-by: Anup Patel <anup.patel at wdc.com>
> 
> Reviewed-by: Alistair Francis <alistair.francis at wdc.com>
> 
> Alistair
> 
> > ---
> >  include/sbi/sbi_platform.h | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/include/sbi/sbi_platform.h b/include/sbi/sbi_platform.h
> > index c252628..cc7e3ff 100644
> > --- a/include/sbi/sbi_platform.h
> > +++ b/include/sbi/sbi_platform.h
> > @@ -152,7 +152,7 @@ struct sbi_platform_operations {
> >                                    const struct sbi_trap_regs *regs,
> >                                    unsigned long *out_value,
> >                                    struct sbi_trap_info *out_trap); -}
> > __packed;
> > +};
> >
> >  /** Platform default per-HART stack size for exception/interrupt
> > handling */
> >  #define SBI_PLATFORM_DEFAULT_HART_STACK_SIZE   8192 @@ -199,7
> +199,7
> > @@ struct sbi_platform {
> >          * 2. HART id < SBI_HARTMASK_MAX_BITS
> >          */
> >         const u32 *hart_index2id;
> > -} __packed;
> > +};
> >
> >  /** Get pointer to sbi_platform for sbi_scratch pointer */
> >  #define sbi_platform_ptr(__s) \

Applied this patch to the riscv/opensbi repo

Regards,
Anup