[PATCH 1/3] include: sbi: No need to pack struct sbi_trap_regs

Anup Patel anup.patel at wdc.com
Wed Jan 13 05:06:55 EST 2021


All members in struct sbi_trap_regs are of machine word size so
no need to pack this structure. This also allows GCC to generate
more optimized instruction sequence when accessing members of
struct sbi_trap_regs.

Reported-by: Paul Campbell <taniwha at gmail.com>
Signed-off-by: Anup Patel <anup.patel at wdc.com>
---
 include/sbi/sbi_trap.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/sbi/sbi_trap.h b/include/sbi/sbi_trap.h
index 04001df..5fb94f9 100644
--- a/include/sbi/sbi_trap.h
+++ b/include/sbi/sbi_trap.h
@@ -186,7 +186,7 @@ struct sbi_trap_regs {
 	unsigned long mstatus;
 	/** mstatusH register state (only for 32-bit) */
 	unsigned long mstatusH;
-} __packed;
+};
 
 /** Representation of trap details */
 struct sbi_trap_info {
-- 
2.25.1




More information about the opensbi mailing list