[PATCH 1/1] lib: sbi: simplify pmp_set()

[Xiang W]

在 2021-12-17星期五的 14:11 +0100，Heinrich Schuchardt写道：
> pmpcfg_csr and pmpcfg_shift are only negative for an unexpected value
> of
> __riscv_xlen. We can immediately return in this case.
> 
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt at canonical.com>
Look good to me

Reviewed-by: Xiang W <wxjstz at 126.com>
> ---
>  lib/sbi/riscv_asm.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/lib/sbi/riscv_asm.c b/lib/sbi/riscv_asm.c
> index 2e2e148..5e5b3d3 100644
> --- a/lib/sbi/riscv_asm.c
> +++ b/lib/sbi/riscv_asm.c
> @@ -261,12 +261,9 @@ int pmp_set(unsigned int n, unsigned long prot,
> unsigned long addr,
>         pmpcfg_csr   = (CSR_PMPCFG0 + (n >> 2)) & ~1;
>         pmpcfg_shift = (n & 7) << 3;
>  #else
> -       pmpcfg_csr   = -1;
> -       pmpcfg_shift = -1;
> +       return SBI_ENOTSUPP;
>  #endif
>         pmpaddr_csr = CSR_PMPADDR0 + n;
> -       if (pmpcfg_csr < 0 || pmpcfg_shift < 0)
> -               return SBI_ENOTSUPP;
>  
>         /* encode PMP config */
>         prot &= ~PMP_A;
> -- 
> 2.33.1
> 
>