[PATCH] lib: sbi_trap: Restore redirect for access faults

Anup Patel anup at brainfault.org
Thu Aug 19 21:53:52 PDT 2021


On Tue, Aug 17, 2021 at 11:48 AM Bin Meng <bmeng.cn at gmail.com> wrote:
>
> On Sat, Aug 14, 2021 at 9:42 PM Samuel Holland <samuel at sholland.org> wrote:
> >
> > commit 764a17d852a8 ("lib: sbi: Implement firmware counters") added
> > switch cases for CAUSE_LOAD_ACCESS and CAUSE_STORE_ACCESS. This caused
> > them to stop being redirected to U or S mode, as that is handled in the
> > default switch case. As a result, an error in userspace could cause the
> > system to hang. Fix this by allowing the acces fault case to fall
> > through to the default case.
> >
> > Signed-off-by: Samuel Holland <samuel at sholland.org>
> > ---
> >  lib/sbi/sbi_trap.c | 7 +++----
> >  1 file changed, 3 insertions(+), 4 deletions(-)
> >
>
> Should have a:
>
> Fixes 764a17d852a8 ("lib: sbi: Implement firmware counters")
> Reviewed-by: Bin Meng <bmeng.cn at gmail.com>

I have included the Fixes tag at time of merging this patch.

Applied this patch to the riscv/opensbi repo.

Thanks,
Anup

>
> --
> opensbi mailing list
> opensbi at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/opensbi



More information about the opensbi mailing list