[PATCH 1/1] lib: utils/serial: Add support for Gaisler APBUART

[Daniel Cederman]

Hello Bin,

2021-04-30 11:16 Bin Meng wrote:
> On Fri, Apr 30, 2021 at 2:37 PM Daniel Cederman <cederman at gaisler.com> 
> wrote:
>> 
>> +
>> +static const struct fdt_match serial_gaisler_match[] = {
>> +       { .compatible = "gaisler,apbuart" },
> 
> Is this an approved compatible string? I did not find such in the
> upstream Linux kernel.
> 

This is the corresponding Linux driver: drivers/tty/serial/apbuart.c. It 
was originally written for SPARC and does not have a compatible string. 
We have a patch to make the driver usable with RISC-V, but we have not 
upstreamed it yet. I agree with you that it is probably best not to 
commit this patch until the Linux patch has been accepted to avoid name 
conflicts.

Other than the compatible string, does the patch look ok?

Regards,
Daniel