[PATCH 5/5] platform: generic: Don't mark non-MMU HARTs as invalid

[Anup Patel]

> -----Original Message-----
> From: Atish Patra <atishp at atishpatra.org>
> Sent: 11 September 2020 06:42
> To: Anup Patel <Anup.Patel at wdc.com>
> Cc: Atish Patra <Atish.Patra at wdc.com>; Alistair Francis
> <Alistair.Francis at wdc.com>; Anup Patel <anup at brainfault.org>; OpenSBI
> <opensbi at lists.infradead.org>
> Subject: Re: [PATCH 5/5] platform: generic: Don't mark non-MMU HARTs as
> invalid
> 
> On Wed, Sep 9, 2020 at 7:51 AM Anup Patel <anup.patel at wdc.com> wrote:
> >
> > Currently, the generic platform fw_platform_init() marks non-MMU HARTs
> > (e.g. E-core on SiFive Unleashed) as invalid. This means such non-MMU
> > HARTs won't be allowed to go ahead by sbi_init().
> >
> > The sbi_init() now has a check for next stage privilege mode when
> > selecting coldboot HART. This check will force non-MMU HARTS (i.e.
> > HARTs without S-mode) to proceed in warmboot path and wait in the HSM
> > STOPPED state. This means we don't need to mark non-MMU HARTs as
> > invalid in generic platform fw_platform_init().
> >
> > Signed-off-by: Anup Patel <anup.patel at wdc.com>
> > ---
> >  platform/generic/platform.c | 6 +-----
> >  1 file changed, 1 insertion(+), 5 deletions(-)
> >
> > diff --git a/platform/generic/platform.c b/platform/generic/platform.c
> > index c3cf423..d902e71 100644
> > --- a/platform/generic/platform.c
> > +++ b/platform/generic/platform.c
> > @@ -71,7 +71,7 @@ unsigned long fw_platform_init(unsigned long arg0,
> unsigned long arg1,
> >                                 unsigned long arg2, unsigned long arg3,
> >                                 unsigned long arg4)  {
> > -       const char *model, *mmu_type;
> > +       const char *model;
> >         void *fdt = (void *)arg1;
> >         u32 hartid, hart_count = 0;
> >         int rc, root_offset, cpus_offset, cpu_offset, len; @@ -101,10
> > +101,6 @@ unsigned long fw_platform_init(unsigned long arg0, unsigned
> long arg1,
> >                 if (SBI_HARTMASK_MAX_BITS <= hartid)
> >                         continue;
> >
> > -               mmu_type = fdt_getprop(fdt, cpu_offset, "mmu-type", &len);
> > -               if (!mmu_type || !len)
> > -                       hartid = -1U;
> > -
> >                 generic_hart_index2id[hart_count++] = hartid;
> >         }
> >
> > --
> > 2.25.1
> >
> >
> > --
> > opensbi mailing list
> > opensbi at lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/opensbi
> 
> 
> 
> Reviewed-by: Atish Patra <atish.patra at wdc.com>

Applied this patch to the riscv/opensbi repo

Regards,
Anup