[PATCH 03/11] lib: sbi: Fix domain_count check in sbi_domain_finalize()

Alistair Francis Alistair.Francis at wdc.com
Mon Nov 30 20:59:49 EST 2020


On Sat, 2020-11-21 at 15:17 +0530, Anup Patel wrote:
> The domain_count check in sbi_domain_finalize() for newly discovered
> domain is incorrect and should be reversed.
> 
> Signed-off-by: Anup Patel <anup.patel at wdc.com>

Reviewed-by: Alistair Francis <alistair.francis at wdc.com>

Alistair

> ---
>  lib/sbi/sbi_domain.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/sbi/sbi_domain.c b/lib/sbi/sbi_domain.c
> index 4c98a1b..ac920b8 100644
> --- a/lib/sbi/sbi_domain.c
> +++ b/lib/sbi/sbi_domain.c
> @@ -371,7 +371,7 @@ int sbi_domain_finalize(struct sbi_scratch
> *scratch, u32 cold_hartid)
>                          * Ensure that we have room for Domain Index
> to
>                          * HART ID mapping
>                          */
> -                       if (domain_count <= SBI_DOMAIN_MAX_INDEX)
> +                       if (SBI_DOMAIN_MAX_INDEX <= domain_count)
>                                 return SBI_ENOSPC;
>  
>                         /* Sanitize discovered domain */



More information about the opensbi mailing list