[PATCH 3/3] Use standard C string APIs in FDT helper

[Anup Patel]

> -----Original Message-----
> From: Abner Chang <abner.chang at hpe.com>
> Sent: 23 July 2020 07:24
> To: opensbi at lists.infradead.org
> Cc: abner.chang at hpe.com; Atish Patra <Atish.Patra at wdc.com>; Anup Patel
> <Anup.Patel at wdc.com>; Daniel Schaefer <daniel.schaefer at hpe.com>
> Subject: [PATCH 3/3] Use standard C string APIs in FDT helper
> 
> Use strncmp instead of using sbi_strcmp directly in fdthelp.c.
> 
> Signed-off-by: Abner Chang <abner.chang at hpe.com>
> 
> Cc: Atish Patra <atish.patra at wdc.com>
> Cc: Anup Patel <anup.patel at wdc.com>
> Cc: Daniel Schaefer <daniel.schaefer at hpe.com>
> ---
>  lib/utils/fdt/fdt_helper.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/utils/fdt/fdt_helper.c b/lib/utils/fdt/fdt_helper.c index
> 78077f7..aec73a0 100644
> --- a/lib/utils/fdt/fdt_helper.c
> +++ b/lib/utils/fdt/fdt_helper.c
> @@ -123,7 +123,7 @@ int fdt_parse_hart_id(void *fdt, int cpu_offset, u32
> *hartid)
>  	prop = fdt_getprop(fdt, cpu_offset, "device_type", &len);
>  	if (!prop || !len)
>  		return SBI_EINVAL;
> -	if (sbi_strcmp(prop, "cpu"))
> +	if (strncmp (prop, "cpu", strlen ("cpu")))
>  		return SBI_EINVAL;
> 
>  	val = fdt_getprop(fdt, cpu_offset, "reg", &len);
> --
> 2.25.0

Looks good to me.

Reviewed-by: Anup Patel <anup.patel at wdc.com>

Regards,
Anup