[PATCH 03/11] lib: sbi: Fix domain_count check in sbi_domain_finalize()

Atish Patra atishp at atishpatra.org
Thu Dec 3 18:56:50 EST 2020


On Sat, Nov 21, 2020 at 2:52 PM Anup Patel <anup.patel at wdc.com> wrote:
>
> The domain_count check in sbi_domain_finalize() for newly discovered
> domain is incorrect and should be reversed.
>
> Signed-off-by: Anup Patel <anup.patel at wdc.com>
> ---
>  lib/sbi/sbi_domain.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/sbi/sbi_domain.c b/lib/sbi/sbi_domain.c
> index 4c98a1b..ac920b8 100644
> --- a/lib/sbi/sbi_domain.c
> +++ b/lib/sbi/sbi_domain.c
> @@ -371,7 +371,7 @@ int sbi_domain_finalize(struct sbi_scratch *scratch, u32 cold_hartid)
>                          * Ensure that we have room for Domain Index to
>                          * HART ID mapping
>                          */
> -                       if (domain_count <= SBI_DOMAIN_MAX_INDEX)
> +                       if (SBI_DOMAIN_MAX_INDEX <= domain_count)
>                                 return SBI_ENOSPC;
>
>                         /* Sanitize discovered domain */
> --
> 2.25.1
>
>
> --
> opensbi mailing list
> opensbi at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/opensbi


Reviewed-by: Atish Patra <atish.patra at wdc.com>

-- 
Regards,
Atish



More information about the opensbi mailing list