[PATCH] utils: Use cpu_to_fdt32() when writing to fdt

Atish Patra Atish.Patra at wdc.com
Wed Jul 24 16:29:17 PDT 2019


On Wed, 2019-07-24 at 11:38 +0200, Georg Kotheimer wrote:
> Although it does not make a functional difference, both
> cpu_to_fdt32()
> and fdt32_to_cpu() pass on to CPU_TO_FDT32, we should use
> cpu_to_fdt32()
> to be semantically correct.
> 
> Signed-off-by: Georg Kotheimer <georg.kotheimer at kernkonzept.com>
> ---
>  lib/utils/irqchip/plic.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/utils/irqchip/plic.c b/lib/utils/irqchip/plic.c
> index 2cd055e..5dcbce0 100644
> --- a/lib/utils/irqchip/plic.c
> +++ b/lib/utils/irqchip/plic.c
> @@ -68,7 +68,7 @@ void plic_fdt_fixup(void *fdt, const char *compat)
>  
>  	for (i = 0; i < (cells_count / 2); i++) {
>  		if (fdt32_to_cpu(cells[2 * i + 1]) == IRQ_M_EXT)
> -			cells[2 * i + 1] = fdt32_to_cpu(0xffffffff);
> +			cells[2 * i + 1] = cpu_to_fdt32(0xffffffff);
>  	}
>  }
>  

Thanks for catching this!

Reviewed-by: Atish Patra <atish.patra at wdc.com>

Regards,
Atish


More information about the opensbi mailing list