[PATCH v2] store length of ESP encryption and HMAC keys so that they can be manipulated separately for both Juniper and GP

Daniel Lenski dlenski at gmail.com
Sun May 14 21:21:24 PDT 2017


Yeah, I had added the constants in a separate commit on the
globalprotect branch. Sorry about that. Upcoming version actually
built and tested on a Juniper VPN. Derp derp derp. :-(

On Sun, May 14, 2017 at 9:00 PM, David Woodhouse <dwmw2 at infradead.org> wrote:
> On Sun, 2017-05-14 at 17:06 -0700, Daniel Lenski wrote:
>>
>> +               if (data[0] == ENC_AES_128_CBC) {
>>                         enctype = "AES-128";
>> -               else if (data[0] == 0x05)
>> +                       vpninfo->enc_key_len = 16;
>> +               } else if (data[0] == ENC_AES_256_CBC) {
>
> Applies now. Doesn't build.
>
> oncp.c: In function ‘process_attr’:
> oncp.c:305:18: error: ‘ENC_AES_128_CBC’ undeclared (first use in this
> function)
>    if (data[0] == ENC_AES_128_CBC) {
>                   ^
> oncp.c:305:18: note: each undeclared identifier is reported only once
> for each function it appears in
> oncp.c:308:25: error: ‘ENC_AES_256_CBC’ undeclared (first use in this
> function)
>    } else if (data[0] == ENC_AES_256_CBC) {
>                          ^
> oncp.c:324:18: error: ‘HMAC_MD5’ undeclared (first use in this
> function)
>    if (data[0] == HMAC_MD5) {
>                   ^
> oncp.c:327:25: error: ‘HMAC_SHA1’ undeclared (first use in this
> function)
>    } else if (data[0] == HMAC_SHA1) {
>                          ^



More information about the openconnect-devel mailing list