[PATCH 2/8] add OC_FORM_OPT_FILL_{USERNAME, PASSWORD} flags to hint at purpose of a form field without requiring a specific name

David Woodhouse dwmw2 at infradead.org
Mon Aug 14 08:37:47 PDT 2017

On Sat, 2017-05-20 at 15:43 -0700, Daniel Lenski wrote:
> diff --git a/openconnect.h b/openconnect.h
> index e97dacb..06bf48e 100644
> --- a/openconnect.h
> +++ b/openconnect.h
> @@ -208,6 +208,8 @@ struct oc_vpn_proto {
>  #define OC_FORM_OPT_IGNORE             0x0001
>  #define OC_FORM_OPT_NUMERIC            0x0002
> +#define OC_FORM_OPT_FILL_USERNAME      0x0004
> +#define OC_FORM_OPT_FILL_PASSWORD      0x0008

Hm... that's a public API, and you're using it for something which is
purely internal. That special-casing for 'username' and 'password'
fields is something that only openconnect(8) / main.c does.

Perhaps use the high bits like OC_FORM_OPT_SECOND_AUTH does? (Although
I don't see why that uses 0x8000 instead of 0x80000000 FWIW).

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 4938 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/openconnect-devel/attachments/20170814/f2e0e20f/attachment-0001.bin>

More information about the openconnect-devel mailing list