[PATCH 2/3] Make buf_append_urlencoded() percent-encode fewer characters.

Nikos Mavrogiannopoulos n.mavrogiannopoulos at gmail.com
Sun Oct 16 09:09:53 PDT 2016


On Sun, 2016-10-16 at 16:28 +0100, David Woodhouse wrote:
> On Sun, 2016-10-16 at 15:30 +0200, Nikos Mavrogiannopoulos wrote:
> > 
> > On Fri, 2016-10-14 at 18:46 -0700, Daniel Lenski wrote:
> > > 
> > > Per RFC 3986, the characters '-', '_', '.', '~' don't need to be
> > > percent-encoded anywhere in a URL or query string.  And ' ' can
> > > simply be
> > > replaced with '+' rather than "%20".
> > That would break communication with ocserv. As it is now, ocserv
> > parsing code is the reverse of what openconnect emits rather than a
> > full rfc3986 parser.
> For that you mean just the + vs. %20 bit, yes? The rest we can apply?

Yes, only the '+' part should be problematic.




More information about the openconnect-devel mailing list