[PATCH V2 11/11] library: Add setup_tun() callback

Woodhouse, David david.woodhouse at intel.com
Wed Feb 10 13:35:00 PST 2016


On Mon, 2016-02-08 at 22:34 -0800, Kevin Cernekee wrote:
> 
>   openconnect_obtain_cookie()
>   openconnect_make_cstp_connection()
>   openconnect_setup_dtls()
>   openconnect_get_ip_info()
>   # ask the OS to create the tun interface
>   openconnect_setup_tun_fd()
>   openconnect_mainloop()
> 
> But now that MTU is calculated a few seconds after the mainloop starts
> up, it is necessary to provide a callback so that the calling application
> can create a tun interface with the correct MTU.

What happens if apps *don't* update, and the library is just updated
(with no soname bump) without the application being changed.

Does the dynamic MTU detection still happen, but achieve nothing and
basically leave things as they were in OpenConnect 7.05?

If so, that fact needs noting in the commit message.

If not, we need an soname bump. Or to make it compatible by explicitly
checking for a setup_tun callback being set, and changing the library
behaviour accordingly.


-- 
David Woodhouse                            Open Source Technology Centre
David.Woodhouse at intel.com                              Intel Corporation

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3437 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/openconnect-devel/attachments/20160210/a4fbb25e/attachment.bin>


More information about the openconnect-devel mailing list