[PATCH 1/6] use windows types and return codes for socket errors

[David Woodhouse]

On Tue, 2014-08-26 at 14:52 +0200, Nikos Mavrogiannopoulos wrote:
> 
> I should have tested that. Should I add it in openconnect-internal.h?

Well, dumb_socketpair() is Windows-only anyway, so the only other
location you'd need it is library.c? You could just localise it there;
perhaps with the *same* ifdef hack that we now have in
openconnect-internal.h

Or you could still use a #define that's visible to everyone (as in your
first attempt), but just use a name other than SOCKET for it.
OPENCONNECT_CMD_SOCKET would do. It's ugly... but all solutions to this
are ugly so I'm not going to be too picky.

-- 
dwmw2

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 5745 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/openconnect-devel/attachments/20140826/91dc11c9/attachment.bin>