Add TOTP (RFC6238) one-time password support
John Morrissey
jwm at horde.net
Thu Mar 21 11:07:57 EDT 2013
On Thu, Mar 21, 2013 at 01:09:52PM +0000, David Woodhouse wrote:
> On Mon, 2013-03-18 at 23:53 -0400, John Morrissey wrote:
> > @@ -86,7 +87,7 @@
> > #define OC_FORM_OPT_PASSWORD 2
> > #define OC_FORM_OPT_SELECT 3
> > #define OC_FORM_OPT_HIDDEN 4
> > -#define OC_FORM_OPT_STOKEN 5
> > +#define OC_FORM_OPT_TOKEN 5
>
> Strictly speaking, that's an ABI change worthy of an soname bump. It's
> worse than that, in fact, because it's an *API* change too, and existing
> code wouldn't even rebuild correctly.
>
> However, I don't think there *is* any existing code which uses
> OC_FORM_OPT_STOKEN. Kevin allegedly has NetworkManager patches, but
> that's it. Fabian, I don't think you've done anything with stoken yet,
> have you?
>
> So I'm inclined to be naughty and just accept this...
Or #define OC_FORM_OPT_STOKEN 5 as well and mention that it's deprecated,
as a hedge.
john
--
John Morrissey _o /\ ---- __o
jwm at horde.net _-< \_ / \ ---- < \,
www.horde.net/ __(_)/_(_)________/ \_______(_) /_(_)__
More information about the openconnect-devel
mailing list