Add TOTP (RFC6238) one-time password support

David Woodhouse dwmw2 at infradead.org
Thu Mar 21 09:09:52 EDT 2013


On Mon, 2013-03-18 at 23:53 -0400, John Morrissey wrote:
> @@ -86,7 +87,7 @@
>  #define OC_FORM_OPT_PASSWORD   2
>  #define OC_FORM_OPT_SELECT     3
>  #define OC_FORM_OPT_HIDDEN     4
> -#define OC_FORM_OPT_STOKEN     5
> +#define OC_FORM_OPT_TOKEN      5

Strictly speaking, that's an ABI change worthy of an soname bump. It's
worse than that, in fact, because it's an *API* change too, and existing
code wouldn't even rebuild correctly.

However, I don't think there *is* any existing code which uses
OC_FORM_OPT_STOKEN. Kevin allegedly has NetworkManager patches, but
that's it. Fabian, I don't think you've done anything with stoken yet,
have you?

So I'm inclined to be naughty and just accept this...

-- 
dwmw2
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 6171 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/openconnect-devel/attachments/20130321/0d4afabb/attachment.bin>


More information about the openconnect-devel mailing list