[PATCH nm-openconnect 3/3] Add support for TOTP software tokens

Woodhouse, David david.woodhouse at intel.com
Mon Jun 3 17:27:36 EDT 2013


Applied; thanks.

On Sun, 2013-03-24 at 18:15 -0700, Kevin Cernekee wrote:
> @@ -380,8 +383,11 @@ init_token_ui (OpenconnectPluginUiWidget *self,
>         GtkTextBuffer *buffer;
>         const char *value;
>  
> -       /* don't advertise stoken properties if we can't use them anyway */
> -       if (!openconnect_has_stoken_support ())
> +       /*
> +        * don't advertise software token properties if we can't use them anyway
> +        * TODO: Fix up the dialog accordingly if e.g. stoken is present but oath is missing
> +        */
> +       if (!openconnect_has_stoken_support () && !openconnect_has_oath_support ())
>                 return TRUE;
>  

I suppose we ought to be building up the options in this dialog manually
rather than having them in the .ui file?


More information about the openconnect-devel mailing list