[PATCH v2] android: fix typo in #include header

Jason openconnect at lakedaemon.net
Tue Jul 19 11:13:05 EDT 2011


On Tue, Jul 19, 2011 at 08:04:36AM -0700, David Woodhouse wrote:
> On Tue, 2011-07-19 at 09:44 -0400, Jason wrote:
> > The only outstanding change I forsee is status updates.  I'd like to
> > copy all log messages to stderr so mtpd can parse/pass up to java.
> > I'll dump the env to a separate pipe so that I can filter out the
> > non-cisco vars.  
> 
> An option to use the normal write_progress() routine in *addition* to
> syslog_progress()?
> 
> Something like '--syslog-copy', with a progress function that simply
> calls both?

Do you ever forsee this feature being useful outside of Android?  Is
there ever a situation in Android where we wouldn't want status updates?

If it's only and always in Android, then why not just add a vfprintf to
the Android version of syslog_progress() ?  I don't see a need for
unnecessary complexity, however, it's not functionally different.  So,
whichever you prefer, I'll do.

thx,

Jason.



More information about the openconnect-devel mailing list