[PATCH v2] maple_tree: document that "last" in mtree_insert_range() is inclusive

SeongJae Park sj at kernel.org
Thu May 14 07:23:11 PDT 2026


On Thu, 14 May 2026 10:07:23 -0400 Steven Rostedt <rostedt at kernel.org> wrote:

> On Wed, 13 May 2026 18:42:04 -0700
> SeongJae Park <sj at kernel.org> wrote:
> 
> > >  /**
> > > - * mtree_insert_range() - Insert an entry at a given range if there is no value.
> > > + * mtree_insert_range() - Insert an entry from [first, last] at a given range
> > > + *                        if there is no value.  
> > 
> > It feels "at a given range" bit repetitive to me.  s/at a given range// ?
> > 
> 
> I just added what Liam suggested.

Liam's suggestion was very sligtly different.

: Something like this:
:
: mtree_insert_range() - Insert an entry from [first, last] if there isn't
: an entry within that range.

So I assumed you intentionally reworded it, but might forgot erasing 'at a
given range'.  English is never my mother tongue language, but Geminit also
told me dropping 'at a given range' makes it bit easier to read.  Hence I just
wanted to check if this is intentional.

> Should I send a v3?

The current wording works for me.  English is never my mother tongue langauage,
so I cannot judge.  I just wanted to make sure this is the intended change.  So
I will leave the decision to you and others.

If we decide to rewording, I think Andrew could help without asking you to
resned v3 for such a minor change.


Thanks,
SJ

[...]



More information about the maple-tree mailing list