[PATCH v5 12/14] maple_tree: Sheaf conversion
Suren Baghdasaryan
surenb at google.com
Tue Aug 26 19:07:10 PDT 2025
On Tue, Aug 26, 2025 at 7:22 AM Liam R. Howlett <Liam.Howlett at oracle.com> wrote:
>
> * Suren Baghdasaryan <surenb at google.com> [250822 16:18]:
> > On Wed, Jul 23, 2025 at 6:35 AM Vlastimil Babka <vbabka at suse.cz> wrote:
> > >
> > > From: "Liam R. Howlett" <Liam.Howlett at oracle.com>
> > >
> > > Use sheaves instead of bulk allocations. This should speed up the
> > > allocations and the return path of unused allocations.
> >
> > Nice cleanup!
> >
> > >
> > > Remove push/pop of nodes from maple state.
> > > Remove unnecessary testing
> > > ifdef out other testing that probably will be deleted
> >
> > Should we simply remove them if they are unused?
>
> Yes, I think it's time to drop them.
>
> >
> > > Fix testcase for testing race
> > > Move some testing around in the same commit.
> >
> > Would it be possible to separate test changes from kernel changes into
> > another patch? Kernel part looks good to me but I don't know enough
> > about these tests to vote on that.
>
> Yes. I'll do that.
>
> I'll drop testing first then the feature so that testing will continue
> to pass on bisection.
>
> I will also stop moving tests around in this change.
>
> >
> > >
> > > Signed-off-by: Liam R. Howlett <Liam.Howlett at oracle.com>
> > > Signed-off-by: Vlastimil Babka <vbabka at suse.cz>
> > > ---
> > > include/linux/maple_tree.h | 6 +-
> > > lib/maple_tree.c | 331 ++++----------------
> > > lib/test_maple_tree.c | 8 +
> > > tools/testing/radix-tree/maple.c | 632 +++++++--------------------------------
> > > tools/testing/shared/linux.c | 8 +-
> > > 5 files changed, 185 insertions(+), 800 deletions(-)
>
> ...
>
> I didn't see any changes in the code block, but please let me know if I
> missed them.
I was referring to the changes in include/linux/maple_tree.h and
lib/maple_tree.c as kernel changes and the rest as test changes.
>
>
> Thanks,
> Liam
More information about the maple-tree
mailing list