[Maple Tree] Report of duplicate code at the function mtree_range_walk()
JaeJoon Jung
rgbi3307 at gmail.com
Tue Feb 15 17:53:19 PST 2022
Ok, thanks.
On Tue, 15 Feb 2022 at 23:45, Liam Howlett <liam.howlett at oracle.com> wrote:
>
> * JaeJoon Jung <rgbi3307 at gmail.com> [220214 22:37]:
> > I found duplicate code at the function mtree_range_walk() in
> > lib/maple_tree.c as below:
> >
> > diff --git a/lib/maple_tree.c b/lib/maple_tree.c
> > index be9d9af7ad0c..1ff58dee5162 100644
> > --- a/lib/maple_tree.c
> > +++ b/lib/maple_tree.c
> > @@ -2804,7 +2804,7 @@ static inline void *mtree_range_walk(struct ma_state *mas)
> > if (pivots[offset] >= mas->index) {
> > prev_max = max;
> > prev_min = min;
> > - max = pivots[offset];
> > goto next;
> > }
> > ...
> > if (likely(offset > end) && pivots[offset]) {
> > next:
> > max = pivots[offset];
> > }
>
> Thanks, I will include this in v6.
>
> >
> > And,
> > There is error message on build tools/testing/radix-tree/maple as below:
> >
> > cc: error: ma_xa_benchmark.o: No such file or directory
>
> I think the error was on building everything, but I have dropped this as
> well from the Makefile for v6.
>
> Thanks.
More information about the maple-tree
mailing list