[PATCH] arch/um: remove unused varible err in remove_files_and_dir()

alexs at kernel.org alexs at kernel.org
Tue Jan 6 22:40:09 PST 2026


From: Alex Shi <alexs at kernel.org>

err is duplicated with errno, and never used. So remove it to fix warnning:
arch/um/os-Linux/umid.c:139:16: warning: variable 'err' set but not used [-Wunused-but-set-variable]
  139 |         int fd, p, n, err;
      |                       ^

Reported-by: kernel test robot <lkp at intel.com>
Signed-off-by: Alex Shi <alexs at kernel.org>
Cc: linux-um at lists.infradead.org
Cc: Johannes Berg <johannes at sipsolutions.net>
Cc: Anton Ivanov <anton.ivanov at cambridgegreys.com>
Cc: Richard Weinberger <richard at nod.at>
---
 arch/um/os-Linux/umid.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/um/os-Linux/umid.c b/arch/um/os-Linux/umid.c
index eb523ab1e218..6b488be2c545 100644
--- a/arch/um/os-Linux/umid.c
+++ b/arch/um/os-Linux/umid.c
@@ -136,7 +136,7 @@ static int remove_files_and_dir(char *dir)
 static inline int is_umdir_used(char *dir)
 {
 	char pid[sizeof("nnnnnnnnn")], *end, *file;
-	int fd, p, n, err;
+	int fd, p, n;
 	size_t filelen = strlen(dir) + sizeof("/pid") + 1;
 
 	file = malloc(filelen);
@@ -155,7 +155,6 @@ static inline int is_umdir_used(char *dir)
 		goto out;
 	}
 
-	err = 0;
 	n = read(fd, pid, sizeof(pid));
 	if (n < 0) {
 		printk(UM_KERN_ERR "is_umdir_used : couldn't read pid file "
-- 
2.43.0




More information about the linux-um mailing list