Patch "minmax: make generic MIN() and MAX() macros available everywhere" has been added to the 6.6-stable tree

[Greg KH]

On Mon, Sep 22, 2025 at 02:27:00PM +0200, gregkh at linuxfoundation.org wrote:
> 
> This is a note to let you know that I've just added the patch titled
> 
>     minmax: make generic MIN() and MAX() macros available everywhere
> 
> to the 6.6-stable tree which can be found at:
>     http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> 
> The filename of the patch is:
>      minmax-make-generic-min-and-max-macros-available-everywhere.patch
> and it can be found in the queue-6.6 subdirectory.
> 
> If you, or anyone else, feels it should not be added to the stable tree,
> please let <stable at vger.kernel.org> know about it.
> 
> 
> >From prvs=353d6d59a=farbere at amazon.com Mon Sep 22 12:35:15 2025
> From: Eliav Farber <farbere at amazon.com>
> Date: Mon, 22 Sep 2025 10:32:30 +0000
> Subject: minmax: make generic MIN() and MAX() macros available everywhere
> To: <richard at nod.at>, <anton.ivanov at cambridgegreys.com>, <johannes at sipsolutions.net>, <dave.hansen at linux.intel.com>, <luto at kernel.org>, <peterz at infradead.org>, <tglx at linutronix.de>, <mingo at redhat.com>, <bp at alien8.de>, <x86 at kernel.org>, <hpa at zytor.com>, <tony.luck at intel.com>, <qiuxu.zhuo at intel.com>, <james.morse at arm.com>, <mchehab at kernel.org>, <rric at kernel.org>, <harry.wentland at amd.com>, <sunpeng.li at amd.com>, <Rodrigo.Siqueira at amd.com>, <alexander.deucher at amd.com>, <christian.koenig at amd.com>, <Xinhui.Pan at amd.com>, <airlied at gmail.com>, <daniel at ffwll.ch>, <evan.quan at amd.com>, <maarten.lankhorst at linux.intel.com>, <mripard at kernel.org>, <tzimmermann at suse.de>, <jdelvare at suse.com>, <linux at roeck-us.net>, <linus.walleij at linaro.org>, <dmitry.torokhov at gmail.com>, <wens at csie.org>, <jernej.skrabec at gmail.com>, <samuel at sholland.org>, <agk at redhat.com>, <snitzer at kernel.org>, <dm-devel at lists.linux.dev>, <mailhol.vincent at wanadoo.fr>, <wg at grandegger.com>, <mkl at pengutronix.de>, <davem at davemloft.net>, <edu
>  mazet at google.com>, <kuba at kernel.org>, <pabeni at redhat.com>, <alexandre.torgue at foss.st.com>, <joabreu at synopsys.com>, <mcoquelin.stm32 at gmail.com>, <krzysztof.kozlowski at linaro.org>, <malattia at linux.it>, <hdegoede at redhat.com>, <ilpo.jarvinen at linux.intel.com>, <markgross at kernel.org>, <artur.paszkiewicz at intel.com>, <jejb at linux.ibm.com>, <martin.petersen at oracle.com>, <sakari.ailus at linux.intel.com>, <gregkh at linuxfoundation.org>, <clm at fb.com>, <josef at toxicpanda.com>, <dsterba at suse.com>, <luc.vanoostenryck at gmail.com>, <rostedt at goodmis.org>, <mhiramat at kernel.org>, <pmladek at suse.com>, <andriy.shevchenko at linux.intel.com>, <linux at rasmusvillemoes.dk>, <senozhatsky at chromium.org>, <minchan at kernel.org>, <akpm at linux-foundation.org>, <dsahern at kernel.org>, <shuah at kernel.org>, <keescook at chromium.org>, <wad at chromium.org>, <farbere at amazon.com>, <David.Laight at ACULAB.COM>, <arnd at kernel.org>, <linux-um at lists.infradead.org>, <linux-kernel at vger.kernel.org>, <linux-edac at vger.kernel.org>, <amd-gfx at lists.freedeskto
>  p.org>, <dri-devel at lists.freedesktop.org>, <linux-hwmon at vger.kernel.org>, <linux-input at vger.kernel.org>, <linux-arm-kernel at lists.infradead.org>, <linux-sunxi at lists.linux.dev>, <linux-media at vger.kernel.org>, <linux-can at vger.kernel.org>, <netdev at vger.kernel.org>, <linux-stm32 at st-md-mailman.stormreply.com>, <platform-driver-x86 at vger.kernel.org>, <linux-scsi at vger.kernel.org>, <linux-staging at lists.linux.dev>, <linux-btrfs at vger.kernel.org>, <linux-sparse at vger.kernel.org>, <linux-trace-kernel at vger.kernel.org>, <linux-mm at kvack.org>, <linux-kselftest at vger.kernel.org>, <bpf at vger.kernel.org>, <stable at vger.kernel.org>
> Cc: Linus Torvalds <torvalds at linux-foundation.org>, David Laight <David.Laight at aculab.com>, Lorenzo Stoakes <lorenzo.stoakes at oracle.com>
> Message-ID: <20250922103241.16213-5-farbere at amazon.com>
> 
> From: Linus Torvalds <torvalds at linux-foundation.org>
> 
> [ Upstream commit 1a251f52cfdc417c84411a056bc142cbd77baef4 ]
> 
> This just standardizes the use of MIN() and MAX() macros, with the very
> traditional semantics.  The goal is to use these for C constant
> expressions and for top-level / static initializers, and so be able to
> simplify the min()/max() macros.
> 
> These macro names were used by various kernel code - they are very
> traditional, after all - and all such users have been fixed up, with a
> few different approaches:
> 
>  - trivial duplicated macro definitions have been removed
> 
>    Note that 'trivial' here means that it's obviously kernel code that
>    already included all the major kernel headers, and thus gets the new
>    generic MIN/MAX macros automatically.
> 
>  - non-trivial duplicated macro definitions are guarded with #ifndef
> 
>    This is the "yes, they define their own versions, but no, the include
>    situation is not entirely obvious, and maybe they don't get the
>    generic version automatically" case.
> 
>  - strange use case #1
> 
>    A couple of drivers decided that the way they want to describe their
>    versioning is with
> 
> 	#define MAJ 1
> 	#define MIN 2
> 	#define DRV_VERSION __stringify(MAJ) "." __stringify(MIN)
> 
>    which adds zero value and I just did my Alexander the Great
>    impersonation, and rewrote that pointless Gordian knot as
> 
> 	#define DRV_VERSION "1.2"
> 
>    instead.
> 
>  - strange use case #2
> 
>    A couple of drivers thought that it's a good idea to have a random
>    'MIN' or 'MAX' define for a value or index into a table, rather than
>    the traditional macro that takes arguments.
> 
>    These values were re-written as C enum's instead. The new
>    function-line macros only expand when followed by an open
>    parenthesis, and thus don't clash with enum use.
> 
> Happily, there weren't really all that many of these cases, and a lot of
> users already had the pattern of using '#ifndef' guarding (or in one
> case just using '#undef MIN') before defining their own private version
> that does the same thing. I left such cases alone.
> 
> Cc: David Laight <David.Laight at aculab.com>
> Cc: Lorenzo Stoakes <lorenzo.stoakes at oracle.com>
> Signed-off-by: Linus Torvalds <torvalds at linux-foundation.org>
> Signed-off-by: Eliav Farber <farbere at amazon.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
> ---
>  arch/um/drivers/mconsole_user.c                                       |    2 
>  drivers/edac/skx_common.h                                             |    1 
>  drivers/gpu/drm/amd/display/modules/hdcp/hdcp_ddc.c                   |    2 
>  drivers/gpu/drm/amd/pm/powerplay/hwmgr/ppevvmath.h                    |   14 ++++-

Oops, nope, this patch breaks the amd driver's build :(

I'll drop this patch and stop here on this patch series.  Please fix
this up and resend the remaining ones after it builds properly.

thanks,

greg k-h