[PATCH 01/11] VFS: discard err2 in filename_create()
Al Viro
viro at zeniv.linux.org.uk
Tue Aug 12 20:22:19 PDT 2025
On Tue, Aug 12, 2025 at 12:25:04PM +1000, NeilBrown wrote:
> During the time when "err2" holds a value, "error" does not hold any
> meaningful value. So there is no need for two different err variables.
> This patch discards "err2" and uses "error' throughout.
I'd probably replace the first sentence with something like this:
Since 204a575e91f3 "VFS: add common error checks to lookup_one_qstr_excl()"
filename_create() does not need to stash the error value from mnt_want_write()
into a separate variable - the logics that used to clobber 'error' after the
call of mnt_want_write() has migrated into lookup_one_qstr_excl().
More information about the linux-um
mailing list