[PATCH v2] rust: helpers: Remove volatile qualifier from io helpers
Miguel Ojeda
miguel.ojeda.sandonis at gmail.com
Tue Apr 15 10:29:54 PDT 2025
On Tue, Apr 15, 2025 at 6:54 PM Arnd Bergmann <arnd at arndb.de> wrote:
>
> Rihgt, I tried this last week when it came up first, removing the
> 'volatile' annotations in the asm-generic/io.h header and then
> all the ones that caused build regressions on arm/arm64/x86
> randconfig and allmodconfig builds. This patch is a little
> longer than my original version as I did run into a few
> regressions later.
>
> As far as I can tell, none of these volatile annotations have
> any actual effect, and most of them date back to ancient kernels
> where this may have been required.
>
> Leaving it out of the rust interface is clearly the right way,
> and it shouldn't be too hard to upstream the changes below
> when we need to, but I also don't see any priority to send these.
> If anyone wants to help out, I can send them the whole patch.
Thanks a lot Arnd -- then let's go without them on the Rust side. I
will pick it as a fix.
I added an issue in case someone wants to help:
https://github.com/Rust-for-Linux/linux/issues/1156
Cheers,
Miguel
More information about the linux-um
mailing list