[RFC PATCH 13/13] um: nommu: plug nommu code into build system

Hajime Tazaki thehajime at gmail.com
Fri Oct 25 06:05:11 PDT 2024


On Fri, 25 Oct 2024 18:33:06 +0900,
Johannes Berg wrote:
> 
> On Thu, 2024-10-24 at 21:09 +0900, Hajime Tazaki wrote:
> > 
> >  config MMU
> > -	bool
> > +	bool "MMU-based Paged Memory Management Support"
> >  	default y
> 
> "if !64bit" or something

not sure if I understand correctly but where do you suggest to add "if
!64bit" in this block ?

> >  config UML_DMA_EMULATION
> > @@ -187,8 +190,14 @@ config MAGIC_SYSRQ
> >  	  The keys are documented in <file:Documentation/admin-guide/sysrq.rst>. Don't say Y
> >  	  unless you really know what this hack does.
> >  
> > +config ARCH_FORCE_MAX_ORDER
> > +	int "Order of maximal physically contiguous allocations"
> > +	default "10" if MMU
> > +	default "16" if !
> 
> Should there even a be user prompt for it?
> Perhaps "if EXPERT" or something?

I think it's already user-editable but your suggestion is to limit
with 'if EXPERT' ?

> >  config KERNEL_STACK_ORDER
> >  	int "Kernel stack size order"
> > +	default 3 if !MMU
> >  	default 2 if 64BIT
> >  	range 2 10 if 64BIT
> >  	default 1 if !64BIT
> 
> give a different range for !MMU?

will fix it.

-- Hajime



More information about the linux-um mailing list