[PATCH v9 02/10] um: use execveat to create userspace MMs

Benjamin Berg benjamin at sipsolutions.net
Thu Oct 17 05:05:36 PDT 2024


Hi,

On Thu, 2024-10-17 at 10:18 +0200, Johannes Berg wrote:
> [SNIP]
> 
> I wonder now if the SSE instructions generated are memset() and that
> goes away with the patches that Nathan just sent to not have the memset
> (which was due to -ftrivial-auto-var-init) in the first place?

I am guessing it would not fix it. I can reproduce the problem if I add
  __attribute__((aligned(16)))
to the "stack" variable. That is sufficient for GCC to emit an
offending movaps instruction for me. The -ftrivial-auto-var-init=
option will not affect that initialization.

> But anyway all of these pretty much sound reasonable. We don't need much
> to happen in the stub here, simpler is better.

Yeah, and I guess c) really is sufficient by itself.

Benjamin



More information about the linux-um mailing list