-Wmissing-prototypes warnings in user-mode linux

[Johannes Berg]

On Tue, 2024-03-05 at 12:49 +0200, Jani Nikula wrote:
> On Tue, 05 Mar 2024, Johannes Berg <johannes at sipsolutions.net> wrote:
> > On Tue, 2024-03-05 at 12:34 +0200, Jani Nikula wrote:
> > > We're seeing a lot of -Wmissing-prototypes warnings when building
> > > user-mode Linux. For example, our CI hits things like [1], and it's just
> > > extra noise in the build.
> > 
> > Yeah ...
> > 
> > > I started adding some prototypes, but I lost my way around the arch/
> > > subdirectory a bit. I'm not always quite sure what should or could be
> > > included where, or whether a new header should be added instead, etc.,
> > > so it wasn't going as quickly as I'd hoped.
> > > 
> > > Do you perhaps already have plans or, better yet, patches to address
> > > this? Feels like it should be fairly quick for someone familiar with the
> > > arch/um codebase.
> > 
> > I think this series addressed most already?
> > 
> > https://patchwork.ozlabs.org/project/linux-um/list/?series=393619
> > 
> > But I haven't checked myself yet.
> 
> Oh, nice, it certainly helps!
> 
> But after applying that in my branch, I do still get a bunch of
> warnings.
> 

I cleaned up the patchwork a bit now, but looks like we don't have
anything else yet :)

johannes