[PATCH vhost 2/4] virtio: vring_create_virtqueue: pass struct instead of multi parameters
Johannes Berg
johannes at sipsolutions.net
Tue Mar 5 02:55:48 PST 2024
On Mon, 2024-03-04 at 19:47 +0800, Xuan Zhuo wrote:
> Now, we pass multi parameters to vring_create_virtqueue. These parameters
> may from transport or from driver.
>
> vring_create_virtqueue is called by many places.
> Every time, we try to add a new parameter, that is difficult.
>
> If parameters from the driver, that should directly be passed to vring.
> Then the vring can access the config from driver directly.
>
> If parameters from the transport, we squish the parameters to a
> structure. That will be helpful to add new parameter.
>
> Because the virtio_uml.c changes the name, so change the "names" inside
> the virtio_vq_config from "const char *const *names" to
> "const char **names".
>
> Signed-off-by: Xuan Zhuo <xuanzhuo at linux.alibaba.com>
> ---
> arch/um/drivers/virtio_uml.c | 14 +++++---
Looks fine here.
Acked-by: Johannes Berg <johannes at sipsolutions.net>
johannes
More information about the linux-um
mailing list